Skip to content

Add name validation to index prefix #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add name validation to index prefix #4332

wants to merge 4 commits into from

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Oct 20, 2025

Description

Add name validation to index prefix and remove sensitive logs

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from e7d6707 to 1272ad6 Compare October 21, 2025 00:15
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 74.69880% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.13%. Comparing base (66bcde7) to head (a2072e1).

Files with missing lines Patch % Lines
...emorycontainer/memory/MemoryProcessingService.java 71.66% 10 Missing and 7 partials ⚠️
...rycontainer/memory/TransportAddMemoriesAction.java 75.00% 2 Missing ⚠️
...on/memorycontainer/memory/MemorySearchService.java 75.00% 1 Missing ⚠️
...l/action/session/TransportCreateSessionAction.java 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4332      +/-   ##
============================================
- Coverage     80.14%   80.13%   -0.02%     
+ Complexity    10172    10169       -3     
============================================
  Files           854      854              
  Lines         44219    44243      +24     
  Branches       5113     5113              
============================================
+ Hits          35440    35453      +13     
- Misses         6630     6638       +8     
- Partials       2149     2152       +3
Flag Coverage Δ
ml-commons 80.13% <74.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 1272ad6 to 2343286 Compare October 21, 2025 07:10
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 08:17 — with GitHub Actions Failure
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 2343286 to 950732e Compare October 21, 2025 08:17
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 20:07 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 20:07 — with GitHub Actions Failure
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from bc7e3a5 to a2072e1 Compare October 21, 2025 20:09
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 20:11 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 20:11 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 20:11 — with GitHub Actions Failure
dhrubo-os
dhrubo-os previously approved these changes Oct 21, 2025
View reviewed changes
ylwu-amzn
ylwu-amzn previously approved these changes Oct 21, 2025
View reviewed changes
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 21:11 — with GitHub Actions Inactive
@b4sjoo
Log reasons on error
8f4137c 
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo dismissed stale reviews from ylwu-amzn and dhrubo-os via 12e71d0 October 23, 2025 10:23
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from a2072e1 to 12e71d0 Compare October 23, 2025 10:23
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 23, 2025 10:24 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 23, 2025 10:24 — with GitHub Actions Failure
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 12e71d0 to fe1dbe0 Compare October 23, 2025 10:36
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 23, 2025 10:38 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 23, 2025 10:38 — with GitHub Actions Failure
@peterzhuamazon peterzhuamazon mentioned this pull request Oct 23, 2025
Open
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zhangxunmt Zhangxunmt Zhangxunmt left review comments

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@dhrubo-os dhrubo-os dhrubo-os left review comments

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@pyek-bot pyek-bot Awaiting requested review from pyek-bot pyek-bot is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

backport 3.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@b4sjoo @Zhangxunmt @ylwu-amzn @dhrubo-os